[BTC-dev] Excise Hash Truncation Regrind - with manifest.txt

[Shane Kinney]

URL: <http://therealbitcoin.org/ml/btc-dev/attachments/20180923/attachment.txt?sha1=655d12644c55016446e28dc1534b14b45fc79690>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

This is the second regrind of the origial Excise Hash Truncation vpatch
submitted [R.01] by ben_vulpes [R.02].  The first regrind that I submitted
[R.03] did not include a 'manifest.txt' file of all of the vpatches included in
the TRB vtree to date.  This regrind would be a fine time to introduce this
'manifest.txt' based upon the proposed format by trinque [R.04], here [R.05].

The vpatch itself consists of removal of numerous substring calls when writing
to the log file.  Previously, when these log lines are written, a hash would be
truncted to the first twenty characters of the hash.  This is not helpful when
searching through the logs for a specific hash.  Additionally, it also includes
a removal of a block of commented out debug code.  As well as the removal of a
superfluous space at the end of the CWalletTX::GetAccountAmounts function
signature.

The reground vpatch is 'ground on' or based upon the recently added
Aggressive PushGetBlocks Vpatch [R.06].  That is to say, the Excise Hash
Truncation vpatch now has Aggressive PushGetBlocks as an antecedent
(among a handful of others).

The vpatch and corresponding seal (signature) files attached to this email
have been tested on three different of my TRB environments with the current
TRB vtree as it now exists.  It compiles and runs in the testing that I have
conducted myself.

If you would like to help test this reground vpatch, please reach out to me
in #trilema and we'll discuss the methods and ways in which to test this with
the current TRB vtree.

Upon some further testing and review, this vpatch will be added to the main
TRB vtree.

All the best,
mod6

References:
  [R.01]: http://thebitcoin.foundation/ml/btc-dev/2017-December/000282.html
  [R.02]: 4F79 0794 2CA8 B89B 01E2 5A76 2AFA 1A9F D2D0 31DA
  [R.03]: http://thebitcoin.foundation/ml/btc-dev/2018-August/000308.html
  [R.04]: FC66 C0C5 D98C 42A1 D4A9 8B6B 42F9 985A FAB9 53C4
  [R.05]: http://trinque.org/2018/06/02/v-manifest-specification
  [R.06]: http://thebitcoin.foundation/ml/btc-dev/2018-July/000305.html
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (FreeBSD)

iQIcBAEBCgAGBQJbp/RkAAoJEHIXBai3Hq2vZiUP/3qZVJ+oBHZkI8JJ7l13VVVp
RgHEUiYqjl69aLNX9DeC73XF7keE9sQti26XpRp2VNr5RJXXAtOb45++b0VsIWGA
IOy470fI3PgPTWRNQbFTMIJvqIjwr742KWMe5kWeLcc2P3nD0lfRIZaRHYCRKECL
kMC0gvzBeoRx+bx3w4atngmUKN/C49rVxejP6xpdhoTSHl/fchbDoAfT+YMHfOiU
GA3jsNRIyp5FMs0eyB6s9SXPsg4e1v9dVGa9+dmq6uUJzYq6s91bxkSFM/ZVlCy2
Xg3Atib3NbB5zpm0r3iFcHxBHxDcFwVP4edvV+51AGxSSh/e0KBQXIId1O9Q2v1z
VlfH8GySBBijpBSf5QMqUBPwqe7+xnIWRl+JNDw+8PV6E0PzppLq2SdbgJSve0Ep
RV9qnDRVPS3YKUPXVppgm76MIF7OC+WVEG9wViXgt7afv7j2amHYyju2mwj+b4WH
FZHN2P/dCIh8uF0zLyP8HUFXJmCD39BCqDr3yvbi3a6QMLqyH5CtHhh6HGt0ctgc
4rteUHNQq3GMC4f8GGZfXGp/5eUNaKVkcvS2O1+/pJbUeOlPkuG9GSXTkTMjaCM5
4F31P4gKSslt84x1J9c82zsO1gmv9apRQ7iheEN6s5Q67CScCZECVxKOFUp8ujBX
+8/oZsNNH5f8mpB4fxZ/
=8tuY
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mod6_excise_hash_truncation.vpatch
Type: application/octet-stream
Size: 22677 bytes
Desc: not available
URL: <http://therealbitcoin.org/ml/btc-dev/attachments/20180923/mod6_excise_hash_truncation.vpatch?sha1=9abdb060135507152b9a5c7c3b8b98966266c5bd>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mod6_excise_hash_truncation.vpatch.mod6.sig
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://therealbitcoin.org/ml/btc-dev/attachments/20180923/mod6_excise_hash_truncation.vpatch.mod6.sig?sha1=fdf92038ec5dd2df7939c2c9d9fe1179ba9b6b91>